Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Marshal empty interface #26

Merged
merged 1 commit into from
Oct 1, 2020
Merged

fix: Marshal empty interface #26

merged 1 commit into from
Oct 1, 2020

Conversation

xuancanh
Copy link
Contributor

Related issue: #19

Fix the panic "reflect: call of reflect.Value.IsNil on struct Value" when marshalling an empty interface.

@coveralls
Copy link

coveralls commented Sep 30, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 84.615% when pulling d078d0d on xuancanh:master into b3555cb on liip:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 83.59% when pulling 56e3cbe on xuancanh:master into b3555cb on liip:master.

@mweibel mweibel merged commit 040b323 into liip:master Oct 1, 2020
@mweibel
Copy link
Collaborator

mweibel commented Oct 1, 2020

thanks @xuancanh!

@mweibel mweibel mentioned this pull request Oct 1, 2020
Closed
kevinlynx pushed a commit to kevinlynx/sheriff that referenced this pull request Jul 28, 2021
@xuancanh @kevinlynx
fix: Handle empty interface when marshalling (liip#26)
c435f42 
Co-authored-by: Canh Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xuancanh @coveralls @mweibel